Make the Text tool begin editing a selected layer by pressing Enter#3640
Make the Text tool begin editing a selected layer by pressing Enter#3640Annonnymmousss wants to merge 2 commits intoGraphiteEditor:masterfrom
Conversation
| DragStart, | ||
| DragStop, | ||
| EditSelected, | ||
| Enter, |
There was a problem hiding this comment.
You mean the enter message variant right?
There was a problem hiding this comment.
That's the line I am commenting about, yes.
There was a problem hiding this comment.
renamed Enter to BeginEditing
Keavon
changed the title
|
You've done something to really mess up the Git history, I'm not exactly sure what, but please rebase onto the current upstream master so you only have one commit per actual change and remove all the merge commits. Then force push to your fork's branch. |
|
that is because i have again and again sync the fork to graphite master i guess. |
Annonnymmousss
force-pushed
the
feat-enter-text_tool
branch
from
49d01ff to
39849c9
Compare
|
You shouldn't never need to close the PR. |
|
i mistakenly close it while rebasing |
|
No, you never need to open a separate PR, you can just reopen this one. |
|
okayy |
|
@Keavon git history is fixed. |
|
!build |
|
|
After pressing Enter to edit the text, as soon as you type something, you will find that a newline has been added to the text, which is of course not desired. Can you look into a fix for that bug? |
|
sure looking into it |
|
can you a send a video demo of this bug(the newline) as I am unable to reproduce this. Screen.Recording.2026-01-15.at.3.20.40.PM.mov |
|
Hey @Keavon can you please take a look into it. |
|
Can you try testing in Firefox? I might be noticing different behavior in both browsers. Chrome seems to be broken in a different way. I didn't have time to test thoroughly though. |
|
okay ill test it |
|
yes you are correct the bug is in firefox but works perfect in safari and chrome. |
Annonnymmousss
force-pushed
the
feat-enter-text_tool
branch
from
9e70bae to
e068866
Compare
|
@Keavon the Firefox issue it fixed. Kindly review this. |
Annonnymmousss
force-pushed
the
feat-enter-text_tool
branch
from
f5adb73 to
e405040
Compare
2 participants
closes #3637
Screen.Recording.2026-01-15.at.10.16.16.AM.mov
@Keavon is it okay?